Skip to content

chore: remove @Avtrkrb as a code owner - #1213

Merged
will-lamerton merged 2 commits into
mainfrom
chore/codeowners-team
Sep 6, 2026
Merged

chore: remove @Avtrkrb as a code owner#1213
will-lamerton merged 2 commits into
mainfrom
chore/codeowners-team

Conversation

@will-lamerton

@will-lamerton will-lamerton commented Sep 6, 2026

Copy link
Copy Markdown
Member

Removes @Avtrkrb as a code owner.

This is fixing a live defect, not tidying

GitHub's own CODEOWNERS validator currently reports on main:

Unknown owner on line 2: make sure @Avtrkrb exists and has write access
to the repository

That is fallout from moving the account to triage during the permissions pass. A code owner without write access cannot satisfy a code-owner review requirement, and Review gates sets require_code_owner_review: true. The replacement validates clean.

Individuals, not the team — and why

The other six repos in this batch move to @Nano-Collective/core-team. This one deliberately does not.

nc-review flagged the reason on the first version of this PR, correctly, as blocking:

stale-prs.yml parses CODEOWNERS for individual logins and explicitly skips team entries (those containing /). After this PR, the workflow finds zero owners, logs a warning, and returns — silently disabling stale-PR escalation on the main repo.

Verified against the file:

// Teams (containing a slash, e.g. @org/team) are skipped since we
// can't cheaply resolve team membership here.
if (tok.startsWith('@') && !tok.includes('/')) { owners.add(...) }
...
if (owners.size === 0) {
  core.warning('No codeowners parsed; nothing to escalate.');
  return;
}

nanocoder is the only repo in the org with a workflow that reads CODEOWNERS, which is why the other six are safe on the team.

The file now carries a comment explaining the coupling, so the next person to reach for the team knows what to fix first: teach stale-prs.yml to resolve team membership, or centralise it into Nano-Collective/.github per step 9.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

No changeset found

This PR does not add a changeset, so it will not appear in the changelog or trigger a release.

If the change is user-facing, add one:

pnpm changeset

Pick a bump (patch / minor / major) and write the changelog entry in our usual voice ("Added X... Thanks to @you. Closes #123."), then commit the generated .changeset/*.md file.

If this PR is docs-only or a chore that needs no release note, you can ignore this - or run pnpm changeset --empty to record that intentionally.

@github-actions github-actions Bot added the area:ci GitHub Actions and CI label Sep 6, 2026
@will-lamerton will-lamerton changed the title chore: own code through the core team, not individuals chore: remove @Avtrkrb as a code owner Sep 6, 2026
@will-lamerton
will-lamerton merged commit f5f24b7 into main Sep 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci GitHub Actions and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant